Skip to content

New analyser: use placeholder type full name correctly#7112

Merged
JukkaL merged 1 commit intopython:masterfrom
ilevkivskyi:new-fix-typevar
Jul 1, 2019
Merged

New analyser: use placeholder type full name correctly#7112
JukkaL merged 1 commit intopython:masterfrom
ilevkivskyi:new-fix-typevar

Conversation

@ilevkivskyi
Copy link
Copy Markdown
Member

Fixes #7102

This switches from using '<unknown>' to None as full name for placeholder types without a known node (and also update the outdated comment).

@ilevkivskyi ilevkivskyi requested a review from JukkaL July 1, 2019 11:08
Copy link
Copy Markdown
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JukkaL JukkaL merged commit 9e91dc0 into python:master Jul 1, 2019
@ilevkivskyi ilevkivskyi deleted the new-fix-typevar branch July 1, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New analyzer: crash using type variable with forward referenced bound in annotation

2 participants