New semantic analyzer: fix issues with 'X = X' assignments#7144
Merged
New semantic analyzer: fix issues with 'X = X' assignments#7144
Conversation
ilevkivskyi
approved these changes
Jul 3, 2019
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Special-casing this makes sense. I have couple minor suggestions.
| # Fall back to normal assignment analysis. | ||
| return False | ||
| else: | ||
| self.defer() |
Member
There was a problem hiding this comment.
name_not_defined() currently already calls defer(), is this additional defer actually needed?
Also this returns True, I would make it more clear by putting the return directly here.
Collaborator
Author
There was a problem hiding this comment.
The fact that name_not_defined calls defer requires some pretty subtle reasoning so I'd rather keep make it explicit here.
| node.node = sym.node | ||
| node.kind = GDEF | ||
| node.fullname = sym.node.fullname() | ||
| return True |
Member
There was a problem hiding this comment.
With the above this return can be indented one level more.
| [case testNewAnalyzerIdentityAssignment8] | ||
| from typing import Final | ||
| x: Final = 0 | ||
| x = x # E: Cannot assign to final name "x" |
Member
There was a problem hiding this comment.
Great to see so detailed test cases!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We special case these since a more general fix, such as looking
at line numbers of definitions, would break a ton of test cases.
Fixes #6404.