Give error if __exit__ returns False but is declared to return bool#7655
Merged
Give error if __exit__ returns False but is declared to return bool#7655
Conversation
Collaborator
|
Maybe we could also suggest returning |
msullivan
approved these changes
Oct 8, 2019
Collaborator
msullivan
left a comment
There was a problem hiding this comment.
Looks good. This will avoid a pretty tricky failure mode.
Collaborator
Author
That doesn't sound correct, though. If the return type is |
This was referenced Oct 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mypy can give false positives about missing return statements
if
__exit__that always returnsFalseis annotated to returnboolinstead ofLiteral[False].Add new error code and documentation for the error code since
this error condition is not very obvious.
Fixes #7577.
There are two major limitations:
__exit__return type.I'll create a follow-up issues about the above.