Skip to content

Promote memoryview to bytes #7717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 2 commits into from
Oct 15, 2019
Merged

Promote memoryview to bytes #7717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
580f3d7
Promote memoryview to bytes
srittau Oct 15, 2019
9013938
Merge branch 'master' into memoryview-as-bytes
srittau Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mypy/semanal_classprop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
TYPE_PROMOTIONS_PYTHON3 = TYPE_PROMOTIONS.copy() # type: Final
TYPE_PROMOTIONS_PYTHON3.update({
'builtins.bytearray': 'bytes',
'builtins.memoryview': 'bytes',
})

# Hard coded type promotions for Python 2.
Expand All @@ -41,6 +42,7 @@
TYPE_PROMOTIONS_PYTHON2.update({
'builtins.str': 'unicode',
'builtins.bytearray': 'str',
'builtins.memoryview': 'str',
})


Expand Down
5 changes: 5 additions & 0 deletions test-data/unit/check-type-promotion.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ def f(x: bytes) -> None: pass
f(bytearray(b''))
[builtins fixtures/primitives.pyi]

[case testPromoteMemoryviewToBytes]
def f(x: bytes) -> None: pass
f(memoryview(b''))
[builtins fixtures/primitives.pyi]

[case testNarrowingDownFromPromoteTargetType]
y = 0.0
y = 1
Expand Down
5 changes: 5 additions & 0 deletions test-data/unit/fixtures/primitives.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ class bytearray(Sequence[int]):
def __iter__(self) -> Iterator[int]: pass
def __contains__(self, other: object) -> bool: pass
def __getitem__(self, item: int) -> int: pass
class memoryview(Sequence[int]):
def __init__(self, x: bytes) -> None: pass
def __iter__(self) -> Iterator[int]: pass
def __contains__(self, other: object) -> bool: pass
def __getitem__(self, item: int) -> int: pass
class tuple(Generic[T]): pass
class list(Sequence[T]):
def __iter__(self) -> Iterator[T]: pass
Expand Down