Fix incorrect type inference for inherited from Any class #8019
Conversation
TH3CHARLie
changed the title
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
This looks good to me. I'll merge it tomorrow unless @ilevkivskyi or @Michael0x2a have more feedback
| # if so, we also return Any | ||
| if ((isinstance(left_type, Instance) and left_type.type.fallback_to_any) or | ||
| (isinstance(right_type, Instance) and right_type.type.fallback_to_any)): | ||
| any_type = AnyType(TypeOfAny.special_form) |
There was a problem hiding this comment.
I'm not sure if special_form is the right thing here but I'm not totally sure what else to do. from_another_any is correct but digging out the other any is almost certainly not worth bothering.
There was a problem hiding this comment.
I am also not sure about whether special_form is the right thing to go, but clearly directly using from_another_any with either left_type or right_type here is incorrect. To proper use from_another_any, we need a better way to transform the Instance to an Any
|
Oh, I guess please fix the merge conflict |
fixed |
4 participants
resolves #8001