Skip to content

PEP 440: Extend example to clarify 1.dev0 < 1.0.15 #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ncoghlan merged 1 commit into from
Dec 23, 2021
Merged

PEP 440: Extend example to clarify 1.dev0 < 1.0.15 #2108

ncoghlan merged 1 commit into from
Dec 23, 2021

Conversation

@abitrolly
Copy link
Contributor

@abitrolly abitrolly commented Oct 14, 2021 •
edited
Loading 

>>> from packaging.version import Version
>>> Version("1.dev0") > Version("1.0.15")
False

The way to do version check is suggested by @hugovk.

@Rosuav
Copy link
Contributor

Rosuav commented Oct 14, 2021

Not sure what you're proving there, since you're adding "1.0.15" prior to "1.1.dev1" - is that a typo and it should have been "1.1.15"?

@abitrolly abitrolly changed the title PEP 440: Extend example to clarify 1.0.dev0 < 1.0.15 PEP 440: Extend example to clarify 1.dev0 < 1.0.15 Oct 14, 2021
@abitrolly
Copy link
Contributor Author

abitrolly commented Oct 14, 2021 •
edited
Loading

There was a typo, but for 1.dev0.

1.0.15 is added, because the spec is missing it in the list for the comparison.

@abitrolly
440: Extend example to clarify 1.dev0 < 1.0.15
ea906ce 
    >>> from packaging.version import Version
    >>> Version("1.dev0") > Version("1.0.15")
    False
@abitrolly
Copy link
Contributor Author

abitrolly commented Oct 14, 2021

Amended the commit message to correct info.

@abitrolly
Copy link
Contributor Author

abitrolly commented Oct 14, 2021

Interesting that 1.dev0 < 1.0.dev456. It still somehow doesn't compile in my head.

@abitrolly
Copy link
Contributor Author

abitrolly commented Nov 1, 2021

So, any news?

@gvanrossum
Copy link
Member

gvanrossum commented Nov 1, 2021

I have no knowledge about this spec.

@pfmoore
Copy link
Member

pfmoore commented Nov 1, 2021

Ping @ncoghlan @dstufft as PEP authors

@ncoghlan ncoghlan merged commit b072483 into python:main Dec 23, 2021
@ncoghlan
Copy link
Contributor

ncoghlan commented Dec 23, 2021

Not sure it's really needed, but I don't think it hurts either, so OK :)

@abitrolly abitrolly deleted the patch-2 branch December 23, 2021 17:03
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pfmoore pfmoore pfmoore approved these changes

@dstufft dstufft Awaiting requested review from dstufft

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@abitrolly @Rosuav @gvanrossum @pfmoore @ncoghlan @the-knights-who-say-ni