Skip to content

Conversation

@JelleZijlstra
Copy link
Member

No description provided.

@JelleZijlstra JelleZijlstra requested a review from a team as a code owner April 23, 2022 16:48
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two uses of "I" which I've suggested turning into plural or neutral language as the rest of the document seems to use "we".

A couple of small suggestions elsewise.

A

@CAM-Gerlach CAM-Gerlach added the new-pep A new draft PEP submitted for initial review label Apr 23, 2022
@CAM-Gerlach
Copy link
Member

Hey @JelleZijlstra , would you like me to proofread and suggest copyedits on this?

@JelleZijlstra
Copy link
Member Author

@CAM-Gerlach yes please! Can't guarantee I'll agree with all your suggestions though :)

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go! In a lot of places, I provided multiple different possible options for you to consider that resolved an issue, if you didn't like the first one (or I myself had no strong preference).

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to see this happen! A few thoughts from me below :)

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more small points :)

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me :)

@JelleZijlstra JelleZijlstra merged commit 0cb0066 into python:main Apr 25, 2022
@JelleZijlstra JelleZijlstra deleted the bufferpep branch April 25, 2022 03:39
@JelleZijlstra
Copy link
Member Author

Thanks everyone for the feedback! I just merged the PR so it shows up on the official site. If you have further textual suggestions, feel free to put a note here, open a PR, give me a handwritten note at PyCon, or let me know in whatever other way you can think of.

@gvanrossum
Copy link
Member

Carrier pigeon.

@CAM-Gerlach
Copy link
Member

Interpretive dance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-pep A new draft PEP submitted for initial review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants