Add Typing Topic #2670
Merged
Add Typing Topic #2670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM-Gerlach
reviewed
Jun 25, 2022
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
JelleZijlstra
requested review from
a team,
AA-Turner,
ambv,
gvanrossum,
ilevkivskyi,
larryhastings and
lisroach
as code owners
CAM-Gerlach
reviewed
Jul 2, 2022
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
At least in the packaging PEPs, we put the Topic below the Type, which seems to make sense, so probably worth being consistent here like the other headers are.
Also, one wording suggestion.
CAM-Gerlach
approved these changes
Oct 7, 2022
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
LGTM now; thanks @JelleZijlstra
Member
|
And it's live! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.