Skip to content

PEP 646: Mark as Final #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hugovk wants to merge 1 commit into from
Closed

PEP 646: Mark as Final #3671

hugovk wants to merge 1 commit into from

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Feb 15, 2024 •
edited by github-actions bot
Loading

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

Helps #3579 and #2872.

📚 Documentation preview 📚: https://pep-previews--3671.org.readthedocs.build/

@hugovk hugovk requested a review from gvanrossum as a code owner February 15, 2024 07:29
@hugovk hugovk mentioned this pull request Feb 15, 2024
Closed
16 tasks
JelleZijlstra
JelleZijlstra reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP 646 actually also made some grammar changes that as far as I can tell aren't documented in the language reference. I'll open an issue on CPython.

@hugovk hugovk marked this pull request as draft February 15, 2024 15:52
@JelleZijlstra JelleZijlstra mentioned this pull request Feb 15, 2024
Closed
raea3225
raea3225 reviewed May 7, 2024
View reviewed changes
@raea3225

This comment was marked as abuse.

Sign in to view
@hugovk

This comment was marked as resolved.

Sign in to view
@hugovk
Copy link
Member Author

hugovk commented Jun 27, 2024

Done in #3832.

@hugovk hugovk closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

+1 more reviewer

@raea3225 raea3225 raea3225 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk @raea3225 @JelleZijlstra