PEP 744: Additional updates from discussion thread #3861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
brandtbucher
reviewed
Aug 8, 2024
Member
brandtbucher
left a comment
brandtbucher
left a comment
There was a problem hiding this comment.
Thanks for this! A few thoughts I had while reading through:
Contributor
|
Nice work @savannahostrowski. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some additional comments from #3850 (review). I've chosen to address the comment around the JIT environment variable in the JIT's README (see python/cpython#121635) since I think that's maybe valuable to contributors and that file is linked from the PEP.
I've also added myself to CODEOWNERS for this file.
📚 Documentation preview 📚: https://pep-previews--3861.org.readthedocs.build/