-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 819: JSON Package Metadata #4751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is the first revision of a PEP to change package metadata to JSON format.
Introduce a ``WHEEL.json`` file as well.
|
Let's GO 🚀 ! |
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor suggestions:
One point I don't believe I saw covered is installed package metadata - I imagine the PEP should just call for copying the METADATA.json file if present in the binary distribution.
Thanks,
Adam
peps/pep-0819.rst
Outdated
| in the root directory of the project sources. Tools that prefer the JSON | ||
| formatted metadata file MUST check for the existence of a ``METADATA.json`` | ||
| in the source distribution before reading the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems circular?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, perhaps the first sentence is unclear. METADATA.json is still optional (since older packages may not have it), so if it does exist it should go at the root of the sources. The second sentence would probably be much better written as "Tools MUST NOT assume the METADATA.json file exists in source distributions."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, rewrote this paragraph, hopefully much clearer!
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Good point! |
Basic requirements (all PEP Types)
pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEPheaderAuthororSponsor, and formally confirmed their approvalAuthor,Status(Draft),TypeandCreatedheaders filled out correctlyPEP-Delegate,Topic,RequiresandReplacesheaders completed if appropriate.github/CODEOWNERSfor the PEPStandards Track requirements
How to Teach ThisPython-Versionset to valid (pre-beta) future Python version, if relevantDiscussions-ToandPost-History📚 Documentation preview 📚: https://pep-previews--4751.org.readthedocs.build/pep-0819/