Skip to content

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Jul 8, 2024

Follow on from #99.

PyLong_GetSign will be added in 3.14.0a0:

I was getting an error building with latest main:

      In file included from src/encode.c:28:
      src/thirdparty/pythoncapi_compat.h:1285:1: error: static declaration of 'PyLong_GetSign' follows non-static declaration
      PyLong_GetSign(PyObject *obj, int *sign) {
      ^
      /Users/hugo/github/python/cpython/main/Include/cpython/longobject.h:66:17: note: previous declaration is here
      PyAPI_FUNC(int) PyLong_GetSign(PyObject *v, int *sign);
                      ^
      1 error generated.

Fix the version check and comment.

@vstinner vstinner merged commit ea1f7f6 into python:main Jul 8, 2024
@vstinner
Copy link
Member

vstinner commented Jul 8, 2024

Merged, thank you.

@hugovk hugovk deleted the fix-PyLong_GetSign-version branch July 8, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants