Define _PyUnicode_DecodeUnicodeEscape even on Python 3.6+#171
Define _PyUnicode_DecodeUnicodeEscape even on Python 3.6+#171srittau merged 1 commit intopython:masterfrom
Conversation
|
Some OSes on the CI install 3.9.7 and some install 3.9.8, which is convenient. It passes on both. |
|
Awesome, thank you! |
|
My knowledge of Python internals and typed_ast is very limited, but wouldn't it be safer to get rid of Edit: And that would mean the following block never gets called. |
|
My knowledge of typed_ast is nonexistent. I have no idea. I think this is a shim needed to support pre-3.6 Python as well. |
|
Well, let's merge this. I will send a separate PR trying my idea. |
|
So the case where we hit that block previously is, for example: The only user visible difference I've been able to see is that if running with e.g. |
Fixes #169
I have tested this on 3.9.8, 3.9.7 and 3.10.0 only.The CI tested this more.