Make syslog setlogmask, LOG_MASK and LOG_UPTO positional-only
#10756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminalaee
force-pushed
the
update-syslog-allowlist
branch
from
8741a6a to
562ec39
Compare
aminalaee
changed the title
setlogmask, LOG_MASK and LOG_UPTO positional-only Python 3.12+
aminalaee
changed the title
setlogmask, LOG_MASK and LOG_UPTO positional-only Python 3.12+setlogmask, LOG_MASK and LOG_UPTO positional-only
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
approved these changes
Sep 24, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks! Weird that stubtest wasn't emitting an error on Python <3.12, but it does indeed seem like these have always been positional-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime argument has changed for the functions in Python3.12+.
Not sure if it makes sense to follow #6812 and make it positional-only here or have different signatures.