mypy-protobuf v3.5: Fix and run protobuf generation scripts #10915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JelleZijlstra Suggested update to your PR, this should fix everything in both protobuf generation scripts (except
PYTHON_PROTOBUF_VERSIONbeing4.21.8)METADATA.tomlupdatesync_tensorflow_protobuf_stubs.shto work when running from any locationsync_tensorflow_protobuf_stubs.shwhen it failed midway (the repo clone is extremely slow, even with the optimsation I added)tensorflow/tsl/protobuf/*.protoas it is a dependency of generated modulestensorflow/core/protobuf/coordination_service_pb2.pyifrom the suppressions as it is no longer a generated module