-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[fpdf2] add compatibility with fpdf2 2.7.6 #10932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The pipeline answered the above question for me :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
For entirely new modules which are missing from the stub, mypy's stubgen tool can be pretty useful for generating baseline stubs |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I completed bringing the stubs up to date with v2.7.6. I used mypy's stubgen tool and compared the two versions. There's one place where I replaced |
srittau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few things I noticed below.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srittau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mschoettle Just using float seems to work fine. I suggest we don't use Number.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
@srittau Thanks a lot for fixing the weird |
Release Notes: https://github.com/py-pdf/fpdf2/blob/master/CHANGELOG.md#276---2023-10-11
Changes
txttotextand brings all the other stubs up to date.I am wondering whether it would be better to addtextas an additional argument instead?This PR currently only covers what's listed in the "Deprecated" section of the release notes. It does not cover the new methodtext_columns(https://py-pdf.github.io/fpdf2/TextColumns.html). Let me know if this should be added as well at the same time.Closes #10609