Skip to content

psycopg2: Fix missing Protocol base class in file protocols #10943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 1 commit into from
Oct 28, 2023
Merged

psycopg2: Fix missing Protocol base class in file protocols #10943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions stubs/psycopg2/@tests/test_cases/check_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import io
from typing_extensions import assert_type

import psycopg2.extensions
Expand Down Expand Up @@ -54,3 +55,8 @@ class MyCursor(psycopg2.extensions.cursor):
assert_type(dconn.cursor("test-dcur", None), psycopg2.extras.DictCursor)
assert_type(dconn.cursor("test-dcur", cursor_factory=None), psycopg2.extras.DictCursor)
assert_type(dconn.cursor("test-dcur", cursor_factory=MyCursor), MyCursor)

# file protocols
# --------------
cur = conn.cursor()
cur.copy_from(io.StringIO(), "table")
4 changes: 2 additions & 2 deletions stubs/psycopg2/psycopg2/_psycopg.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ threadsafety: int

__libpq_version__: int

class _SupportsReadAndReadline(SupportsRead[str], SupportsReadline[str]): ...
class _SupportsReadAndReadlineAndWrite(_SupportsReadAndReadline, SupportsWrite[str]): ...
class _SupportsReadAndReadline(SupportsRead[str], SupportsReadline[str], Protocol): ...
class _SupportsReadAndReadlineAndWrite(_SupportsReadAndReadline, SupportsWrite[str], Protocol): ...

class cursor:
arraysize: int
Expand Down