Skip to content

Direct Union replacements for ConvertibleToInt/ConvertibleToFloat #11022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexWaygood merged 3 commits into from
Nov 29, 2023
Merged

Direct Union replacements for ConvertibleToInt/ConvertibleToFloat #11022

AlexWaygood merged 3 commits into from
Nov 29, 2023

Conversation

@Avasam
Copy link
Collaborator

@Avasam Avasam commented Nov 12, 2023

Extracted from #11003 . Only does direct replacements of the full aliased union.

@Avasam Avasam mentioned this pull request Nov 12, 2023
Merged
@github-actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I still think we should hold off at least a few days before merging, though -- there were a few regressions in mypy 1.7, so it's very possible that not everyone will be able to upgrade just yet (and this alias is only available in _typeshed if people are using the very latest version of mypy)

@Avasam
Copy link
Collaborator Author

Avasam commented Nov 12, 2023 •
edited
Loading

I still think we should hold off at least a few days before merging, though -- there were a few regressions in mypy 1.7, so it's very possible that not everyone will be able to upgrade just yet

Agreed. I mistook the typeshed sync to be in 1.6 otherwise I would've waited a bit more before opening #11003

@AlexWaygood
Copy link
Member

AlexWaygood commented Nov 29, 2023

I think we're good to go on this now!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 4687faa into python:main Nov 29, 2023
@Avasam Avasam deleted the Direct-Union-replacements-for-ConvertibleToInt/ConvertibleToFloat branch November 29, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Avasam @AlexWaygood