Skip to content

Improve a few dataclass reprs in stubsabot #11050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 3 commits into from
Nov 21, 2023
Merged

Improve a few dataclass reprs in stubsabot #11050

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b8c561
Improve a few dataclass reprs in stubsabot
AlexWaygood Nov 21, 2023
0c03081
Remove unnecessary change
AlexWaygood Nov 21, 2023
b682d0d
don't need a custom repr for `DiffAnalysis`
AlexWaygood Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scripts/stubsabot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import urllib.parse
import zipfile
from collections.abc import Iterator, Mapping, Sequence
from dataclasses import dataclass
from dataclasses import dataclass, field
from http import HTTPStatus
from pathlib import Path
from typing import Annotated, Any, ClassVar, NamedTuple
Expand Down Expand Up @@ -105,8 +105,8 @@ def _best_effort_version(version: VersionString) -> packaging.version.Version:
class PypiInfo:
distribution: str
pypi_root: str
releases: dict[VersionString, list[ReleaseDownload]]
info: dict[str, Any]
releases: dict[VersionString, list[ReleaseDownload]] = field(repr=False)
info: dict[str, Any] = field(repr=False)

def get_release(self, *, version: VersionString) -> PypiReleaseDownload:
# prefer wheels, since it's what most users will get / it's pretty easy to mess up MANIFEST
Expand Down Expand Up @@ -244,7 +244,7 @@ def get_github_api_headers() -> Mapping[str, str]:
@dataclass
class GithubInfo:
repo_path: str
tags: list[dict[str, Any]]
tags: list[dict[str, Any]] = field(repr=False)


async def get_github_repo_info(session: aiohttp.ClientSession, stub_info: StubInfo) -> GithubInfo | None:
Expand Down Expand Up @@ -323,7 +323,7 @@ def _plural_s(num: int, /) -> str:
return "s" if num != 1 else ""


@dataclass
@dataclass(repr=False)
class DiffAnalysis:
MAXIMUM_NUMBER_OF_FILES_TO_LIST: ClassVar[int] = 7
py_files: list[FileInfo]
Expand Down