Skip to content

Go back to default for useLibraryCodeForTypes & delete removed vscode-python configs. #11101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 1 commit into from
Dec 5, 2023
Merged

Go back to default for useLibraryCodeForTypes & delete removed vscode-python configs. #11101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .vscode/settings.default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,23 +71,11 @@
],
"editor.defaultFormatter": "ms-python.black-formatter"
},
// Use the new dedicated extensions instead
"python.formatting.provider": "none",
"python.linting.enabled": false,
"python.linting.mypyEnabled": false,
"python.linting.flake8Enabled": false,
"python.linting.pycodestyleEnabled": false,
"python.linting.prospectorEnabled": false,
"python.linting.pylamaEnabled": false,
"python.linting.pylintEnabled": false,
"python.linting.banditEnabled": false,
// python.analysis is Pylance (pyright) configurations
"python.analysis.fixAll": [
"source.unusedImports"
// Explicitly omiting "source.convertImportFormat", some stubs use relative imports
],
// Important to use `types-*` and flag untyped dependencies.
"python.analysis.useLibraryCodeForTypes": false,
"python.analysis.typeshedPaths": [
"${workspaceFolder}"
],
Expand Down
2 changes: 0 additions & 2 deletions pyrightconfig.scripts_and_tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
"tests",
],
"typeCheckingMode": "strict",
// Runtime libraries used by typeshed are not all py.typed
"useLibraryCodeForTypes": true,
// More of a lint. Unwanted for typeshed's own code.
"reportImplicitStringConcatenation": "none",
// Extra strict settings
Expand Down