Skip to content

Add annotations and defaults for tkinter.ttk.OptionMenu #11404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Akuli merged 3 commits into from
Feb 12, 2024
Merged

Add annotations and defaults for tkinter.ttk.OptionMenu #11404

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70e5cde
Add types for `ttk.OptionMenu`
MarcellPerger1 Feb 11, 2024
8631522
Add defaults for `ttk.OptionMenu.__init__`
MarcellPerger1 Feb 11, 2024
b090986
Change `variable` to be `StringVar`
MarcellPerger1 Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions stdlib/tkinter/ttk.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,15 +1190,15 @@ class LabeledScale(Frame):
class OptionMenu(Menubutton):
def __init__(
self,
master,
variable,
master: tkinter.Misc | None,
variable: tkinter.StringVar,
default: str | None = None,
*values: str,
# rest of these are keyword-only because *args syntax used above
style: str = ...,
direction: Literal["above", "below", "left", "right", "flush"] = ...,
command: Callable[[tkinter.StringVar], object] | None = ...,
style: str = "",
direction: Literal["above", "below", "left", "right", "flush"] = "below",
command: Callable[[tkinter.StringVar], object] | None = None,
) -> None: ...
# configure, config, cget, destroy are inherited from Menubutton
# destroy and __setitem__ are overridden, signature does not change
def set_menu(self, default: Incomplete | None = None, *values) -> None: ...
def set_menu(self, default: str | None = None, *values: str) -> None: ...