Add defaults for ttk __init__ methods#11405
Merged
Akuli merged 8 commits intopython:mainfrom Feb 12, 2024
Merged
Conversation
NOTE: I've ignored things marked as undocumented or where the type of the default didn't match the annotation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add defaults for ttk
__init__methods, this is like #11391 but fortkinter.ttk(issue #10947).As with #11391, the defaults I filled in are consistent across:
All available github actions runners:
ubuntu-20.04,ubuntu-22.04windows-2019,windows-2022macos-11,macos-12,macos-13I put the defaults for
ttk.OptionMenuin #11404 as I was already modifyingOptionMenuthere so I thought it made more sense to put all theOptionMenuchanges into one PR.Some notes about specific arguments:
padding: The default for this was always""but this doesn't really match the_Paddingtype so I didn't fill this intakefocus: Sometimes this was"ttk::takefocus"but this doesn't match the_TakeFocusValuetype so I didn't fill this in