Skip to content

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 19, 2024

@AlexWaygood
Copy link
Member

AlexWaygood commented Aug 19, 2024

https://github.com/python/typeshed/actions/runs/10452316525/job/28940510185?pr=12553 indicates that we also have pyright issues in JACK-Client, seaborn, shapely and tensorflow -- could you pin those as well? This PR "fixes" those issues because we install all our third-party dependencies together into one environment when running pyright in CI, but adding a pin for those stubs packages is still probably the right thing to do if they no longer work with pyright and the latest numpy version

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Hopefully these numpy pins stop being so problematic soon. I'd guess the churn is just because numpy is having to make a lot of bugfixes right now following the recent numpy 2.0 release

@AlexWaygood AlexWaygood changed the title Pin numpy in networkx stubs Pin numpy in various stubs Aug 19, 2024
@sobolevn sobolevn merged commit 30a2039 into main Aug 19, 2024
@sobolevn sobolevn deleted the fix-ci branch August 19, 2024 12:38
@sobolevn
Copy link
Member Author

Thank you! Now rebasing my original PRs.

max-muoto pushed a commit to max-muoto/typeshed that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daily tests failed on Mon Aug 19 2024

3 participants