[WIP] mark some types as non-hashable #2221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
changed the title
Member
|
So IIUC this requires a mypy change first? |
Member
Yes, see the comment in #2148 |
Member
Author
|
Filed python/mypy#5217 to fix the mypy issue; I'm going to close this until we fix mypy. |
Collaborator
|
Reopening per discussion in #2148. @JelleZijlstra |
Member
Author
|
The merge conflict looks bad, I won't have time to fix it right now. |
srittau
added a commit
to srittau/typeshed
that referenced
this pull request
Sep 3, 2019
Based on @JelleZijlstra's PR python#2221. Fixes python#2148
Collaborator
|
Closing in favor of #3219, which is based on this PR. |
srittau
added a commit
that referenced
this pull request
Sep 4, 2019
Based on @JelleZijlstra's PR #2221. Fixes #2148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2148.
I went over the builtins manually and grepped for other classes in the standard library that declare
__hash__ = None.Some interesting things I learned:
sliceis not hashable, even though it is immutable.decimal.Contextis hashable but_pydecimal.Contextis not. We don't have a stub for_pydecimal, so I made no changes in typeshed.