Skip to content

decorators.pyi: Add Any to Callable[] #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
srittau merged 1 commit into from
Nov 30, 2018
Merged

decorators.pyi: Add Any to Callable[] #2654

srittau merged 1 commit into from
Nov 30, 2018

Conversation

@utkarsh2102
Copy link
Contributor

@utkarsh2102 utkarsh2102 commented Nov 30, 2018

This adds Optional around Callable[...].

Fixes #2615

@srittau
Copy link
Collaborator

srittau commented Nov 30, 2018

This patch will have no effect, since all uses of _Decorator are already marked as Optional. This also won't fix #2615, since that is a problem with the definition of the callable's arguments.

@utkarsh2102 utkarsh2102 force-pushed the decorators-callback branch 3 times, most recently from 79de3db to 5bf4317 Compare November 30, 2018 04:09
srittau
srittau requested changes Nov 30, 2018
View reviewed changes
third_party/2and3/click/decorators.pyi Outdated

_Callback = Callable[
[Context, Union[Option, Parameter], Union[bool, int, str]],
[Context, Union[Option, Parameter], value: Union[Any]],
Copy link
Collaborator

@srittau srittau Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is correct, but the syntax is not. The value: part does not work in Python and the Union with only one element is redundant. This should work:

Suggested change
[Context, Union[Option, Parameter], value: Union[Any]],
[Context, Union[Option, Parameter], Any],

Copy link
Contributor Author

@utkarsh2102 utkarsh2102 Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, on it.

@utkarsh2102 utkarsh2102 changed the title decorators.pyi: Add Optional around Callable[] decorators.pyi: Add Any to Callable[] Nov 30, 2018
@srittau srittau merged commit 407e4bb into python:master Nov 30, 2018
@srittau
Copy link
Collaborator

srittau commented Nov 30, 2018

And another small tip: If you use just the issue number (eg #1234) in commit messages instead of the full URL, it will get linked and closed automatically by GitHub.

@utkarsh2102 utkarsh2102 deleted the decorators-callback branch November 30, 2018 09:36
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
@utkarsh2102
decorators.pyi: Add Any angument to Callable[] (python#2654)
d7fe556 
Fixes python#2615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Click option value type incorrect if multiple=True.

2 participants

@utkarsh2102 @srittau