Skip to content

Properly type the ToJsonString method of time well known types in google protobuf. #2656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 1 commit into from
Nov 30, 2018
Merged

Properly type the ToJsonString method of time well known types in google protobuf. #2656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions third_party/2and3/google/protobuf/internal/well_known_types.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class Any_:
def Is(self, descriptor: Any): ...

class Timestamp:
def ToJsonString(self): ...
def ToJsonString(self) -> str: ...
seconds: Any = ...
nanos: Any = ...
def FromJsonString(self, value: Any) -> None: ...
Expand All @@ -32,7 +32,7 @@ class Timestamp:
def FromDatetime(self, dt: datetime) -> None: ...

class Duration:
def ToJsonString(self): ...
def ToJsonString(self) -> str: ...
seconds: Any = ...
nanos: Any = ...
def FromJsonString(self, value: Any) -> None: ...
Expand All @@ -48,7 +48,7 @@ class Duration:
def FromTimedelta(self, td: Any) -> None: ...

class FieldMask:
def ToJsonString(self): ...
def ToJsonString(self) -> str: ...
def FromJsonString(self, value: Any) -> None: ...
def IsValidForDescriptor(self, message_descriptor: Any): ...
def AllFieldsFromDescriptor(self, message_descriptor: Any) -> None: ...
Expand Down