[third_party/click] add Exit exception definition #2880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
requested changes
Mar 21, 2019
|
|
||
|
|
||
| class Exit(RuntimeError): | ||
| ... |
Collaborator
There was a problem hiding this comment.
According to the PR __init__() takes a code argument.
Contributor
Author
|
Ah yeah, that was a miss on my part. I have added the |
srittau
requested changes
Mar 21, 2019
|
|
||
|
|
||
| class Exit(RuntimeError): | ||
| def __init__(self, code: Optional[int] = ...) -> None: |
Collaborator
There was a problem hiding this comment.
Thanks, one more thing: code should not be optional. Confusingly, Optional does not mean that an argument is optional (assigning a default values does that), it means that a value can also be None, which is not the case here.
srittau
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added to the 7.0 release of click (PR for reference). This may not make sense, as the
__init__stub for click appears to be setting the version to6.6.