Install Black and isort autoformatters#3069
Merged
Merged
Conversation
Notably we keep the convention of 130 line length.
srittau
approved these changes
Jun 17, 2019
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
LGTM, just one comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first stage of adding auto-formatters (#3058), as described by #3062 (comment). This allows users to use Black and isort, but we do not yet document how to do so nor do we enforce it.
We configure isort to work with Black and instruct both tools to use a line length of 130, per the consensus described in #3058 (comment).