Skip to content

fix type of loop.sock_connect #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 3 commits into from
Jun 21, 2019
Merged

fix type of loop.sock_connect #3073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eeb6116
fix type of loop.sock_connect
JelleZijlstra Jun 19, 2019
62dd9f0
remove redundant method
JelleZijlstra Jun 20, 2019
a64db5f
Revert "remove redundant method"
JelleZijlstra Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stdlib/3/asyncio/base_events.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import selectors
from socket import socket
from socket import socket, _Address
import ssl
import sys
from typing import Any, Awaitable, Callable, Dict, Generator, List, Optional, Sequence, Tuple, TypeVar, Union, overload
Expand Down Expand Up @@ -123,7 +123,7 @@ class BaseEventLoop(AbstractEventLoop):
@coroutine
def sock_sendall(self, sock: socket, data: bytes) -> Generator[Any, None, None]: ...
@coroutine
def sock_connect(self, sock: socket, address: str) -> Generator[Any, None, None]: ...
def sock_connect(self, sock: socket, address: _Address) -> Generator[Any, None, None]: ...
Copy link
Copy Markdown
Collaborator

@srittau srittau Jun 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is inherited from AbstractEventLoop and not even overridden in BaseEventLoop, so it can be removed here.

Copy link
Copy Markdown
Collaborator

@srittau srittau Jun 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, my bad. While it seems that BaseEventLoop is indeed abstract, it is not marked as such. Probably easiest to re-add sock_connect().

@coroutine
def sock_accept(self, sock: socket) -> Generator[Any, None, Tuple[socket, Any]]: ...
# Signal handling.
Expand Down
4 changes: 2 additions & 2 deletions stdlib/3/asyncio/events.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import selectors
from socket import socket
from socket import socket, _Address
import ssl
import sys
from typing import Any, Awaitable, Callable, Dict, Generator, List, Optional, Sequence, Tuple, TypeVar, Union, overload
Expand Down Expand Up @@ -185,7 +185,7 @@ class AbstractEventLoop(metaclass=ABCMeta):
def sock_sendall(self, sock: socket, data: bytes) -> Generator[Any, None, None]: ...
@abstractmethod
@coroutine
def sock_connect(self, sock: socket, address: str) -> Generator[Any, None, None]: ...
def sock_connect(self, sock: socket, address: _Address) -> Generator[Any, None, None]: ...
@abstractmethod
@coroutine
def sock_accept(self, sock: socket) -> Generator[Any, None, Tuple[socket, Any]]: ...
Expand Down