Skip to content

Make python 2 subprocess consistent with python 3 #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
msullivan merged 1 commit into from
Jul 19, 2019
Merged

Make python 2 subprocess consistent with python 3 #3132

msullivan merged 1 commit into from
Jul 19, 2019

Conversation

@msullivan
Copy link
Contributor

@msullivan msullivan commented Jul 18, 2019

This makes it consistent with the changes in #3113

ilevkivskyi
ilevkivskyi approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@msullivan msullivan merged commit 90c2c22 into master Jul 19, 2019
@msullivan msullivan deleted the py2-subprocess branch July 19, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

@Michael0x2a Michael0x2a Awaiting requested review from Michael0x2a

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msullivan @ilevkivskyi