-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Fix third_party errors with --disallow-any-generics #3278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9d244e3
Fix third_party errors with --disallow-any-generics
srittau e12ecbc
Revert changes to mock.pyi
srittau a412601
Use imperative style for NamedTuple
srittau 327f7e0
Revert changes to third_party/2/concurrent
srittau 236df08
pytype fixes
srittau 7d9e0f9
pytype fix
srittau 372bb7d
Tighten IO type
srittau 162ea7f
Use Any return type instead of Union
srittau 458cdc3
Use IO[Any] for now, instead of making classes generic
srittau 6b0e69e
Fix error
srittau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,15 @@ | ||
| from typing import AnyStr, Callable, ContextManager, IO, Optional, Text, Type | ||
| from typing import Any, AnyStr, Callable, ContextManager, Generic, IO, Optional, Text, Type, Union | ||
|
|
||
| def replace_atomic(src: AnyStr, dst: AnyStr) -> None: ... | ||
| def move_atomic(src: AnyStr, dst: AnyStr) -> None: ... | ||
| class AtomicWriter(object): | ||
| def __init__(self, path: AnyStr, mode: Text = ..., overwrite: bool = ...) -> None: ... | ||
| def open(self) -> ContextManager[IO]: ... | ||
| def _open(self, get_fileobject: Callable) -> ContextManager[IO]: ... | ||
| def get_fileobject(self, dir: Optional[AnyStr] = ..., **kwargs) -> IO: ... | ||
| def sync(self, f: IO) -> None: ... | ||
| def commit(self, f: IO) -> None: ... | ||
| def rollback(self, f: IO) -> None: ... | ||
| def atomic_write(path: AnyStr, writer_cls: Type[AtomicWriter] = ..., **cls_kwargs: object) -> ContextManager[IO]: ... | ||
| def __init__(self, path: Union[Text, bytes], mode: Text = ..., overwrite: bool = ...) -> None: ... | ||
| def open(self) -> ContextManager[IO[Any]]: ... | ||
| def _open(self, get_fileobject: Callable[..., IO[AnyStr]]) -> ContextManager[IO[AnyStr]]: ... | ||
| def get_fileobject(self, dir: Union[None, Text, bytes] = ..., **kwargs: Any) -> IO[Any]: ... | ||
| def sync(self, f: IO[Any]) -> None: ... | ||
| def commit(self, f: IO[Any]) -> None: ... | ||
| def rollback(self, f: IO[Any]) -> None: ... | ||
| def atomic_write( | ||
| path: Union[Text, bytes], writer_cls: Type[AtomicWriter] = ..., **cls_kwargs: object, | ||
| ) -> ContextManager[IO[Any]]: ... | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.