Skip to content

Added stub for urllib.request.proxy_bypass() #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 24 commits into from
Sep 30, 2019
Merged

Added stub for urllib.request.proxy_bypass() #3283

Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
72913ac
Merge pull request #1 from python/master
jolaf Mar 11, 2019
7cdc4bf
Making vars argument Optional, as it defaults to None in the code and…
Mar 11, 2019
29037b9
Merge pull request #2 from python/master
jolaf Mar 11, 2019
3eed451
email.charset.SHORTEST, QP, BASE64 are not in the stub for Python 2
Mar 11, 2019
d065fdf
email.mime.application.MIMEApplication expects data to be bytes, whil…
Mar 11, 2019
73e625f
Adding #undocumented as requested by @srittau to fix #2830
Mar 11, 2019
9b26ce8
Merge branch 'master' of https://github.com/python/typeshed into pyth…
Mar 12, 2019
2b67cae
Merge pull request #4 from python/master
jolaf Mar 14, 2019
1ee2bef
Merge pull request #5 from python/master
jolaf Jul 18, 2019
603bf4b
NullTranslations._parse() stub added;
Jul 18, 2019
cb8c3e6
Merge pull request #6 from python/master
jolaf Jul 25, 2019
5dc4d4f
Update stdlib/3/gettext.pyi
jolaf Jul 25, 2019
1304aef
Update stdlib/3/gettext.pyi
jolaf Jul 25, 2019
a0fbaef
Suggestions from @srittau implemented
Jul 25, 2019
1206178
Merge branch 'master' of https://github.com/python/typeshed
Sep 19, 2019
1352f9c
Stubs for maxminddb added, approved by the developer, see https://git…
Sep 19, 2019
edf4dde
Fixed stubs for maxminddb
Sep 19, 2019
e3e3f4e
Fixes stubs for maxminddb
Sep 19, 2019
bf03a3f
Fixed stubs for maxminddb
Sep 19, 2019
5dfb034
Update third_party/3/maxminddb/extension.pyi
jolaf Sep 19, 2019
dfdb48f
Fixed according to suggestions from @srittau
Sep 19, 2019
982394c
Merge branch 'master' of github.com:jolaf/typeshed
Sep 19, 2019
7caba43
Merge pull request #8 from python/master
jolaf Sep 30, 2019
49449e0
Added stub for urllib.request.proxy_bypass()
Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stdlib/3/urllib/request.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ def pathname2url(path: str) -> str: ...
def getproxies() -> Dict[str, str]: ...
def parse_http_list(s: str) -> List[str]: ...
def parse_keqv_list(l: List[str]) -> Dict[str, str]: ...
def proxy_bypass(host: str) -> Any: ... # Undocumented
Copy link
Copy Markdown
Collaborator

@srittau srittau Sep 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns int as far as I can see (probably in place of a bool).

Copy link
Copy Markdown
Contributor Author

@jolaf jolaf Sep 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it returns int (0 or 1).

However docstring specifies: Return True, if host should be bypassed.

The actual usage of the function in the module shows the typical usage like if proxy_bypass(...):.

This lead me to conclusion that Any is the proper return type, as it allows bool-like checks and doesn't specify the return type precisely which could produce warnings in runtime type checkers like typeguard.

Copy link
Copy Markdown
Collaborator

@srittau srittau Sep 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable.


class Request:
@property
Expand Down