Revised stubs for geoip2 third party library

[jolaf]

Followup to #3299.

Approved by the developer, see maxmind/GeoIP2-python#70

Also in this PR:

• Stubs for maxminnddb moved from third_party/3 to third_party/2and3 with appropriate adjustement of str replaced with Text.

• stdlib/3/ipaddress.pyi got copied to third_party/2 as this backport is necessary for maxminddb on Python 2. Both copies are adjusted by str replaced with Text.

• Both maxminddb and geoip2 stubs got rid of extra comments.

[jolaf]

Nope, it doesn't work with Python2:

third_party/2and3/geoip2/mixins.pyi:6: error: Dynamic metaclass not supported for 'SimpleEquality'

third_party/2and3/geoip2/records.pyi:11: error: Dynamic metaclass not supported for 'Record'

third_party/2and3/geoip2/records.pyi:16: error: Dynamic metaclass not supported for 'PlaceRecord'

third_party/2and3/geoip2/models.pyi:34: error: Dynamic metaclass not supported for 'SimpleModel'

third_party/2and3/geoip2/database.pyi:6: error: Cannot find module named 'maxminddb.reader'

I suggest moving the stubs back to third_party/3.

[JelleZijlstra]

You can probably just remove the __metaclass__ stuff; I don't think these metaclasses really make a difference in the stubs.

[jolaf]

You can probably just remove the __metaclass__ stuff; I don't think these metaclasses really make a difference in the stubs.

Well, to make this work, I had to also move maxminddb from third_party/3 to third_party/2and3, and also copy ipaddress (that maxminddb depends on) from stdlib/3 to third_party/2, as it is a backport.

[jolaf]

Can we please move on with this?
It would be very nice if this goes into the upcoming mypy release.
Thanks!

[JelleZijlstra]

Sure, just a few small comments

[jolaf]

Sure, just a few small comments

All fixed.

Thank you!