Skip to content

protobuf: Tighten annotations for MergeFromString and ParseFromString. #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 1 commit into from
Oct 10, 2019
Merged

protobuf: Tighten annotations for MergeFromString and ParseFromString. #3333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions third_party/2and3/google/protobuf/message.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
from typing import Any, Sequence, Optional, Tuple, Type, TypeVar
import sys

from typing import Any, Sequence, Optional, Tuple, Type, TypeVar, Union

from .descriptor import (
DescriptorBase,
Expand All @@ -15,6 +17,11 @@ class _ExtensionDict:

_T = TypeVar("_T")

if sys.version_info < (3,):
_Serialized = Union[bytes, buffer, unicode]
else:
_Serialized = bytes

class Message:
DESCRIPTOR: Any
def __deepcopy__(self, memo=...): ...
Expand All @@ -25,8 +32,8 @@ class Message:
def Clear(self) -> None: ...
def SetInParent(self) -> None: ...
def IsInitialized(self) -> bool: ...
def MergeFromString(self, serialized: Any) -> int: ... # TODO: we need to be able to call buffer() on serialized
def ParseFromString(self, serialized: Any) -> None: ...
def MergeFromString(self, serialized: _Serialized) -> int: ...
def ParseFromString(self, serialized: _Serialized) -> None: ...
def SerializeToString(self, deterministic: bool = ...) -> bytes: ...
def SerializePartialToString(self, deterministic: bool = ...) -> bytes: ...
def ListFields(self) -> Sequence[Tuple[FieldDescriptor, Any]]: ...
Expand Down