Skip to content

Change type for urllib headers from Mapping to email.message.Message #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 2 commits into from
Oct 11, 2019
Merged

Change type for urllib headers from Mapping to email.message.Message #3345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b3cb1a
Change type for urllib headers from Mapping to email.message.Message …
mthuurne Oct 11, 2019
789f844
Remove override of 'headers' in HTTPError
mthuurne Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion stdlib/3/urllib/error.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@ class URLError(IOError):
reason: Union[str, BaseException]
class HTTPError(URLError, addinfourl):
code: int
headers: Dict[str, str]
def __init__(self, url, code, msg, hdrs, fp) -> None: ...
class ContentTooShortError(URLError): ...
5 changes: 3 additions & 2 deletions stdlib/3/urllib/response.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# private module, we only expose what's needed

from typing import BinaryIO, Iterable, List, Mapping, Optional, Type, TypeVar
from email.message import Message
from types import TracebackType

_AIUT = TypeVar("_AIUT", bound=addbase)
Expand Down Expand Up @@ -31,8 +32,8 @@ class addbase(BinaryIO):
def writelines(self, lines: Iterable[bytes]) -> None: ...

class addinfo(addbase):
headers: Mapping[str, str]
def info(self) -> Mapping[str, str]: ...
headers: Message
def info(self) -> Message: ...

class addinfourl(addinfo):
url: str
Expand Down