Skip to content

stdlib: Remove duplicated Pickler.reducer_override()#3772

Merged
srittau merged 1 commit into
python:masterfrom
moreati:duplicated-reducer_override
Feb 22, 2020
Merged

stdlib: Remove duplicated Pickler.reducer_override()#3772
srittau merged 1 commit into
python:masterfrom
moreati:duplicated-reducer_override

Conversation

@moreati
Copy link
Copy Markdown
Contributor

@moreati moreati commented Feb 22, 2020

The declaration was present twice. One from #3358 with the bulk Python
3.8 support, the other from #3636 with Pickle protocol 5 support.

@srittau
Copy link
Copy Markdown
Collaborator

srittau commented Feb 22, 2020

Thanks! Please remove pickle.Pickler.reducer_override-redefinition from tests/stubtest_whitelists/py38.txt to fix the CI failure.

The declaration was present twice. One from python#3358 with the bulk Python
3.8 support, the other from python#3636 with Pickle protocol 5 support.
@moreati moreati force-pushed the duplicated-reducer_override branch from 59b6b6f to b45af5e Compare February 22, 2020 16:39
@srittau
Copy link
Copy Markdown
Collaborator

srittau commented Feb 22, 2020

That CI is still failing is unrelated to this PR. I will merge it, once Build #8898 passes.

@srittau srittau merged commit 84c6e67 into python:master Feb 22, 2020
@moreati moreati deleted the duplicated-reducer_override branch February 22, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants