Fix stab for TextIOBase.detach() and add stab for TextIOWrapper.buffer #4036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
reviewed
May 18, 2020
| def __init__( | ||
| self, | ||
| buffer: IO[bytes], | ||
| buffer: BinaryIO, |
Collaborator
There was a problem hiding this comment.
I believe CI fails due to this change. Honestly, I would just leave this instance as IO[bytes] for now. In the future it might make sense to make TextIOWrapper generic over the buffer, but I haven't looked at it in depth.
Collaborator
|
As it happens, I just removed that particular sample from mypy (python/mypy#8838), so if you re-run CI it should pass. |
Collaborator
|
I'm re-running it. It would be great if someone with a large typed code base (hey Dropbox team) could check this, though. Our internal code base doesn't use |
srittau
approved these changes
May 19, 2020
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Ok, let's try this out. If it breaks anything, we can always partly revert before the next mypy release.
vishalkuo
pushed a commit
to vishalkuo/typeshed
that referenced
this pull request
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3993.