PathLike: change to Protocol #4447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Hmm, discovered python/mypy#5775 |
Collaborator
Author
|
Also, the stubtest windows tests aren't doing anything (and I think this has been the case for a while, probably since they were moved to Github Actions) |
JelleZijlstra
requested changes
Aug 16, 2020
| class _PathLike(Generic[AnyStr]): | ||
| def __fspath__(self) -> AnyStr: ... | ||
| _AnyStr_co = TypeVar("_AnyStr_co", str, bytes, covariant=True) | ||
| class _PathLike(Protocol[_AnyStr_co]): |
Member
There was a problem hiding this comment.
Should we put this in _typeshed?
Collaborator
Author
There was a problem hiding this comment.
I'd prefer not to... even if it can be made to work, it'll involve a mypy-typeshed dance (and maybe changes to other type checkers) for little benefit.
Plus _typeshed is for making types internally reusable, and PathLike is already internally (and externally) reusable from os
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Sep 26, 2020
I made PathLike a protocol in python#4447, but it should also be runtime_checkable. Caught by mypy_primer: src/werkzeug/utils.py:646: error: Only @runtime_checkable protocols can be used with instance and class checks
JelleZijlstra
pushed a commit
that referenced
this pull request
Sep 27, 2020
I made PathLike a protocol in #4447, but it should also be runtime_checkable. Caught by mypy_primer: src/werkzeug/utils.py:646: error: Only @runtime_checkable protocols can be used with instance and class checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.