Add _TemporaryFileWrapper #4559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
reviewed
Sep 21, 2020
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
LGTM, just one question below. Also, shouldn't NamedTemporaryFile be changed to return this new type?
| ) -> Optional[bool]: ... | ||
| def __getattr__(self, name: str) -> Any: ... | ||
| def close(self) -> None: ... | ||
| def unlink(self, path: str) -> None: ... |
Collaborator
There was a problem hiding this comment.
Where does this come from? As far as I can see, it's not defined in _TemporaryFileWrapper, so shouldn't it be below the next comment?
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: ignite (https://github.com/pytorch/ignite)
+ ignite/handlers/checkpoint.py:8: error: unused 'type: ignore' comment
+ ignite/handlers/checkpoint.py:627: error: Incompatible types in assignment (expression has type "None", variable has type "_TemporaryFileWrapper") [assignment]
+ ignite/handlers/checkpoint.py:629: error: Incompatible types in assignment (expression has type "IO[bytes]", variable has type "_TemporaryFileWrapper") [assignment]
streamlit (https://github.com/streamlit/streamlit.git)
+ lib/streamlit/hashing.py:491: error: unused 'type: ignore' comment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3096
Adds the _TemporaryFileWrapper type to tempfile. Needed to be added to stubtest's ignores, as its methods are dynamic