markdown: add more stubs #4574
Merged
markdown: add more stubs #4574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 24, 2020 23:59
This makes intention clearer
JelleZijlstra
approved these changes
Sep 25, 2020
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
This is a good start, hopefully we can eventually get rid of the Anys.
| def run(self, parent, blocks) -> None: ... | ||
|
|
||
| class BlockQuoteProcessor(BlockProcessor): | ||
| RE: Any |
Member
There was a problem hiding this comment.
I assume this is a Pattern?
Collaborator
Author
There was a problem hiding this comment.
Made the changes. Not all of them are Pattern, see 8f2c0c5
added 2 commits
September 25, 2020 12:28
I ran `fastmod 'RE: Any$' 'RE: Pattern'`. I then fixed the imports. Then I ran stubtest, which complained about a couple of those substitutions (stubgen will also type as Any if something is a str expression or alias).
This was referenced Sep 26, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently accepted #4426 which contributed some stubs to markdown. However, the stubs weren't complete, which results in false positives (eg, when type checking https://github.com/zulip/zulip).
Here are the rest of the stubs, as generated by
stubgen --export-less -p markdown. I added some type ignores (where the library breaks LSP) and removedAnytype annotations so it's clearer that the annotations aren't done.