Skip to content

Add importlib.resources.files for Python 3.9 #4807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
srittau merged 14 commits into from
Dec 9, 2020
Merged

Add importlib.resources.files for Python 3.9 #4807

srittau merged 14 commits into from
Dec 9, 2020

Conversation

@hynek
Copy link
Member

@hynek hynek commented Dec 8, 2020

No description provided.

@hynek
Copy link
Member Author

hynek commented Dec 8, 2020

Do I really have to create an abc.pyi and re-export all the abcs/Protocols!?

@srittau
Copy link
Collaborator

srittau commented Dec 8, 2020

As far as I can see, the problem is simply that stdlib/3/importlib/abc.pyi doesn't yet have the Traversable protocol.

@hynek
Copy link
Member Author

hynek commented Dec 8, 2020

Hmm I got confused by the error that "found module, but no stubs". 🤔

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Dec 8, 2020

Thanks, this looks good to me! You'll need to add import abc to importlib.abc (or possibly from abc import abstractmethod) and reformat with black

@hynek
Copy link
Member Author

hynek commented Dec 9, 2020

I'm somewhat confused by the remaining failures.

hauntsaninja added 2 commits December 8, 2020 22:33
Use property + abstractmethod to appease pytype
7fc6c81 
abstractproperty has been deprecated for forever too
allowlist a stubtest complaint
3bcd7b7
@hynek
Copy link
Member Author

hynek commented Dec 9, 2020

Thanks @hauntsaninja!

srittau
srittau reviewed Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks mostly good to me with one remark and a nit.

stdlib/3/importlib/abc.pyi
@abstractmethod
def read_bytes(self) -> bytes: ...
@abstractmethod
def read_text(self, encoding: Optional[str] = ...) -> str: ...
Copy link
Collaborator

@srittau srittau Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: The docstring in the implementation is wrong: It says Read contents of self as bytes.

@hynek
Copy link
Member Author

hynek commented Dec 9, 2020

lol wat 😅

free(): invalid pointer
/home/runner/work/_temp/c2a28e77-7168-488e-8f26-da1cbba538c8.sh: line 1:  2734 Aborted                 (core dumped) ./tests/pytype_test.py

I think it needs whitelisting too?

@srittau
Copy link
Collaborator

srittau commented Dec 9, 2020 •
edited
Loading

:( @hynek Sorry for the hassle. Please just add it to the whitelist for now please. Cc @rchen152: It seems pytype crashes here.

Edit: tests/pytype_exclude_list.txt

Edit 2: I'm taking care of it.

@srittau srittau merged commit cb43535 into python:master Dec 9, 2020
@rchen152 rchen152 mentioned this pull request Dec 9, 2020
Closed
@rchen152
Copy link
Collaborator

rchen152 commented Dec 9, 2020

O_o That failure mode I haven't seen before. Sorry for the trouble! I opened google/pytype#757.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hynek @srittau @hauntsaninja @rchen152