concurrent.futures: add _work_queue property to ThreadPoolExecutor #4808
Conversation
`ThreadPoolExecutor` assigns a `queue.SimpleQueue` to `_work_queue` in it's `__init__` method. https://github.com/python/cpython/blob/7cf0aad96d1d20f07d7f0e374885f327c2d5ff27/Lib/concurrent/futures/thread.py#L144
| _S = TypeVar("_S") | ||
|
|
||
| class ThreadPoolExecutor(Executor): | ||
| _work_queue: Any |
There was a problem hiding this comment.
I think we could use a better type, but I'm not sure what it should be
ThreadPoolExecutor assigns it queue.SimpleQueue so it could be that,
but it only uses a few methods so maybe a protocol would be better?
class _QueueLike(Protocol):
def get(self, block: bool = ...) -> Any: ...
def get_nowait(self) -> Any: ...
def put(self, item: Any) -> None: ...Or maybe just queue.Queue?
rel: https://github.com/python/cpython/blob/7cf0aad96d1d20f07d7f0e374885f327c2d5ff27/Lib/concurrent/futures/thread.py#L144
rel: https://github.com/python/cpython/blob/7cf0aad96d1d20f07d7f0e374885f327c2d5ff27/Lib/queue.py
There was a problem hiding this comment.
In 3.6 it's actually a queue.Queue; haven't checked when the change was made. I think we should just use the concrete type that's present at runtime; it doesn't really make sense to introduce a custom protocol for a private field.
2 participants
ThreadPoolExecutorassigns aqueue.SimpleQueueto_work_queueinit's
__init__method.https://github.com/python/cpython/blob/7cf0aad96d1d20f07d7f0e374885f327c2d5ff27/Lib/concurrent/futures/thread.py#L144