Skip to content

tkinter.font.Font: make __getitem__ and cget behave the same #4899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 2 commits into from
Jan 4, 2021
Merged

tkinter.font.Font: make __getitem__ and cget behave the same #4899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
553f6e8
make __getitem__ and cget behave the same
Akuli Jan 4, 2021
fde610f
whitelist __getitem__
Akuli Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion stdlib/3/tkinter/font.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ class Font:
underline: bool = ...,
overstrike: bool = ...,
) -> None: ...
def __getitem__(self, key: str) -> Any: ...
def __setitem__(self, key: str, value: Any) -> None: ...
@overload
def cget(self, option: Literal["family"]) -> str: ...
Expand All @@ -59,6 +58,9 @@ class Font:
@overload
def cget(self, option: Literal["underline", "overstrike"]) -> Literal[0, 1]: ...
@overload
def cget(self, option: str) -> Any: ...
__getitem__ = cget
@overload
def actual(self, option: Literal["family"], displayof: Optional[tkinter.Misc] = ...) -> str: ...
@overload
def actual(self, option: Literal["size"], displayof: Optional[tkinter.Misc] = ...) -> int: ...
Expand Down
1 change: 1 addition & 0 deletions tests/stubtest_whitelists/py3_common.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ timeit.main
tkinter.Misc.grid_propagate
tkinter.Misc.pack_propagate
tkinter.Tk.report_callback_exception # A bit of a lie, since it's actually a method, but typing it as an attribute allows it to be assigned to
tkinter.font.Font.__getitem__ # Argument name differs (doesn't matter for __dunder__ methods)
trace.CoverageResults.__init__
traceback.FrameSummary.__init__
traceback.TracebackException.__init__
Expand Down