-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Upgrade black to 21.4b0 and reformat #5250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This introduces newlines before decorators.
hauntsaninja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer we run with --skip-magic-trailing-comma that I added in this release, thoughts? Helps keep definitions compact when they fit on one line.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This reverts commit 25fc8c2. There seems to be a discrepancy between running black with "--diff --check" and running it without it when using --skip-magic-trailing-comma. It's possible that the options from pyproject.toml are ignored when --check is used.
|
Unfortunately, there is a discrepancy between running black with |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
I couldn't isolate the black problem so far, but the problem can be reproduced locally by running |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Weirdly enough, if I copy my typeshed directory (just doing |
|
Different computer: I am stumped. |
|
I merged the version without skip_magic_trailing_comma for now. |
This introduces newlines before decorators.