Replace 'Text' with 'str' in py3 stdlib #5466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akuli
reviewed
May 16, 2021
| import sys | ||
| from typing import AnyStr, List, Optional, Text, Type, Union | ||
|
|
||
| _EitherStr = Union[bytes, Text] |
Collaborator
There was a problem hiding this comment.
Was this alias really never used?
Collaborator
Author
There was a problem hiding this comment.
I suspect it was used at some point, but not anymore.
Akuli
approved these changes
May 16, 2021
Collaborator
Akuli
left a comment
Akuli
left a comment
There was a problem hiding this comment.
Let's wait until CI works again
Collaborator
Author
|
@JelleZijlstra Thank you for merging. Unfortunately, GitHub Actions has been down since around 7AM UTC, so we should probably wait with further merges, since CI isn't running. |
Member
|
Oops, sorry for missing that. I just saw green checkmarks and didn't look further. |
Collaborator
Author
|
Yeah, it's a bit of a misdesign that "CI is not running" is a "no op", instead of causing errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.