finish types of tkinter.Menu #5583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
The new None error in primer output would error at runtime if a menu was empty, although in this particular case, it is never empty. |
Collaborator
Author
|
Porcupine now gives much more "unused type:ignore comment" errors than before, because it has one such comment for every usage of an untyped function. This way we will hopefully get some indication of how much the primer actually tests tkinter changes. |
srittau
reviewed
Jun 6, 2021
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Nit: Use dict, tuple etc. and int | None etc.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: porcupine (https://github.com/Akuli/porcupine.git)
+ porcupine/menubar.py:80: error: unused "type: ignore" comment
+ porcupine/menubar.py:84: error: unused "type: ignore" comment
+ porcupine/menubar.py:85: error: unused "type: ignore" comment
+ porcupine/menubar.py:114: error: unused "type: ignore" comment
+ porcupine/menubar.py:117: error: unused "type: ignore" comment
+ porcupine/menubar.py:125: error: unused "type: ignore" comment
+ porcupine/menubar.py:150: error: unused "type: ignore" comment
+ porcupine/menubar.py:153: error: unused "type: ignore" comment
+ porcupine/menubar.py:154: error: unused "type: ignore" comment
+ porcupine/menubar.py:155: error: unused "type: ignore" comment
+ porcupine/menubar.py:157: error: unused "type: ignore" comment
+ porcupine/menubar.py:158: error: unused "type: ignore" comment
+ porcupine/menubar.py:165: error: unused "type: ignore" comment
+ porcupine/menubar.py:194: error: Unsupported operand types for + ("None" and "int") [operator]
+ porcupine/menubar.py:194: error: unused "type: ignore" comment
+ porcupine/menubar.py:194: note: Left operand is of type "Optional[int]"
+ porcupine/menubar.py:195: error: unused "type: ignore" comment
|
srittau
approved these changes
Jun 6, 2021
This was referenced Jun 10, 2021
Akuli
added a commit
to Akuli/typeshed
that referenced
this pull request
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already did most of the work in #4903.
This PR will conflict with #5582, but I'll resolve the conflict once one of the PRs gets merged.