Redefined dataclasses.KW_ONLY #5826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s instance. Class instances are illegal to use within a type annotation.
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Makes sense! I'd prefer something like class KW_ONLY: ..., since KW_ONLY is actually an instance of _KW_ONLY_TYPE at runtime, so repurposing it is a little confusing (https://github.com/python/cpython/blob/b6bde9fc42aecad5be0457198d17cfe7b481ad79/Lib/dataclasses.py#L192)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
python/mypy#10867 wanted a similar change (cc @tgallant), so sounds like this is the right direction to take to make this feature implementable for type checkers. There's some CI failures though; you'll probably have to add to the stubtest allowlist. |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
tgallant
added a commit
to tgallant/mypy
that referenced
this pull request
Aug 5, 2021
tgallant
added a commit
to tgallant/mypy
that referenced
this pull request
Aug 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously defined as a class instance, but class instances are illegal when used within a type annotation. It needs to be a class or a type alias that refers to a class.