Switch to PEP-604 syntax in python2 stubs #5915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
This comment has been minimized.
This comment has been minimized.
Member
|
Thanks! I think you'll need to remove a bunch of unused imports. (Pyright catches those, but doesn't run on Python 3.) |
Contributor
Author
|
@JelleZijlstra yep, have to tweak the rewriting script a bit more for the unused imports... |
Collaborator
|
You could use my import cleaner from #5872, although it is much uglier than your scripts, and it can do weird things and requires reviewing the diff manually. |
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: oleg.hoefling oleg.hoefling@gmail.com