Add collections.Container to Python 2/3 #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! I've forgotten how this works for Python 2 (shouldn't they all be imported using "Foo as Foo"?) but it seems to work. Hope you'll contribute more! |
squiddy
added a commit
to unknown-horizons/unknown-horizons
that referenced
this pull request
Oct 20, 2016
Changes include:
* Ignore conditional import for now
* Ignore collections.Container error (wait for
python/typeshed#608)
* Switch to relative imports in horizons.util.shapes
The previous code imported from shapes/__init__.py. I believe mypy
had some problems with import cycles, because it couldn't import Point
etc. This is a bit better, the submodule itself should import
directly, and only then can we provide better imports by reexporting
from __init__.
hswong3i
pushed a commit
to alvistack/python-typeshed
that referenced
this pull request
Jun 4, 2025
Refer to python/cpython#133961 I copied the tests from Python 3.14. Two don't pass but could probably be made to pass by backporting more of annotationlib, but that's more than I think we should do now. Fixes python#608
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.