use to lower-case list and dict, this time with tests #6161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akuli
commented
Oct 13, 2021
| def search_dates( | ||
| text: str, | ||
| languages: List[str] | Tuple[str] | Set[str] | None, | ||
| languages: list[str] | Tuple[str] | Set[str] | None, |
Collaborator
Author
There was a problem hiding this comment.
Tuple[str] appears to be a typo. I'll fix it in a separate PR.
Collaborator
There was a problem hiding this comment.
Maybe this should just be Collection[str] or something
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hauntsaninja
approved these changes
Oct 13, 2021
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks, feel free to merge!
Some potential nits:
- The UnionFinder name is now a little inaccurate
- We should be able to use built-in generics in type aliases etc, so could extend the logic to handle that as well
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5888 I used a script to switch to lower-case
listanddict. This PR adds a CI check for that and also fixes a few occurrences whereListandDicthave slipped through the review.